Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIO performance improvement by making AIOHelper persistent #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wtfuzz
Copy link
Contributor

@wtfuzz wtfuzz commented Apr 23, 2020

Currently each Socket instance is creating a new AIOHelper object on each async operation.

This PR modifies AIOHelper to allow it to be created once at Socket instantiation and is reused per async operation.

The AIOHelper class creates a pair of nng_aio contexts (one for send, and one for recv), so there can be only one pending AIO operation per direction - I think this is ok, but would like feedback on this.

@codypiersall
Copy link
Owner

Things have been pretty busy over in my neck of the woods for the last few months, and I'm trying to pick pynng back up now. I'm hoping to review this soon!

Do you mind rebasing this against master so it will run with the CI that I (finally) fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants